Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MemoryPack #349

Closed
wants to merge 3 commits into from
Closed

Add MemoryPack #349

wants to merge 3 commits into from

Conversation

MonoLogueChi
Copy link
Contributor

The NuGet package needs to respect a few constraints in order to be listed in the curated list:

  • Add a link to the NuGet package: https://www.nuget.org/packages/MemoryPack/
  • It must have non-preview versions (e.g 1.0.0 but not 1.0.0-preview.1)
  • It must provide .NETStandard2.0 assemblies as part of its package
  • The lowest version added must be the lowest .NETStandard2.0 version available
  • The package has been tested with the Unity editor
  • The package has been tested with a Unity standalone player
    • if the package is not compatible with standalone player, please add a comment to a Known issues section to the top level readme.md
  • All package dependencies with .NETStandard 2.0 target must be added to the PR (respecting the same rules above)
    • Note that if a future version of the package adds a new dependency, this dependency will have to be added manually as well

Note: The server will be updated only when a new version tag is pushed on the main branch, not necessarily after merging this pull-request.

@bdovaz
Copy link
Collaborator

bdovaz commented Mar 22, 2024

When you do PRs please try them.

It is in the second one that the same thing happens to you and you are missing a comma.

e0ca62b

@MonoLogueChi
Copy link
Contributor Author

When you do PRs please try them.

It is in the second one that the same thing happens to you and you are missing a comma.

e0ca62b

I'm very sorry, I remembered to add the comma, but I didn't check it when I submitted it.

@MonoLogueChi
Copy link
Contributor Author

Additionally, this package does not specify .NETStandard2.0 and this PR should not be submitted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MonoLogueChi @bdovaz